Wire pipes into torchcomms conda build and update toml configs#966
Open
snarayankh wants to merge 1 commit intometa-pytorch:mainfrom
Open
Wire pipes into torchcomms conda build and update toml configs#966snarayankh wants to merge 1 commit intometa-pytorch:mainfrom
snarayankh wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: Wire the pipes conda feedstock into the torchcomms build and update downstream conda configs to include doca + pipes packages. When USE_PIPES=1, torchcomms adds a USE_PIPES=1 compile definition to the ncclx target so it can resolve Pipes device headers (e.g. CopyUtils.cuh for memcpy_vectorized) from the conda environment. The find_library(pipes) call is an existence check only — pipes is header-only for torchcomms; MCCL links libpipes.so directly at runtime. ## Changes - **setup.py**: Add USE_PIPES flag (default OFF), forward to CMake. - **CMakeLists.txt**: Add USE_PIPES option + find_library existence check + USE_PIPES=1 compile def on ncclx target. - **conda_build_torchcomms.sh**: Auto-detect libpipes.so in conda env and set USE_PIPES accordingly. - **recipe.yaml**: Add pipes as host + run dependency. - **torchcomms.toml / torchcomms_gb200.toml**: Add doca + pipes feedstocks for test environments. - **llama4x build.toml**: Add doca + pipes feedstocks and specs. - **msl/rl build.toml + fair/build.toml**: Add pipes feedstock + spec. Differential Revision: D94942789
meta-cla
bot
added
the
CLA Signed
Contributor
|
@snarayankh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94942789. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Wire the pipes conda feedstock into the torchcomms build and update
downstream conda configs to include doca + pipes packages.
When USE_PIPES=1, torchcomms adds a USE_PIPES=1 compile definition to
the ncclx target so it can resolve Pipes device headers (e.g.
CopyUtils.cuh for memcpy_vectorized) from the conda environment.
The find_library(pipes) call is an existence check only — pipes is
header-only for torchcomms; MCCL links libpipes.so directly at
runtime.
Changes
check + USE_PIPES=1 compile def on ncclx target.
and set USE_PIPES accordingly.
feedstocks for test environments.
Differential Revision: D94942789